Merge branch 'fix-helperbinary-quoted-arguments' into 'master'

Fix helperbinary quoted arguments

See merge request !2

helper/fetchSoicodeBundle.go

@@ -79,12 +79,13 @@ func downloadAndUnpack(url, targetDir string) {
 	}
 
 	tr := tar.NewReader(r)
+tarUnpackLoop:
 	for {
 		header, err := tr.Next()
 
 		switch {
 		case err == io.EOF:
-			return
+			break tarUnpackLoop
 
 		case err != nil:
 			fmt.Printf("Failed to extract: %v", err)
@@ -117,4 +118,5 @@ func downloadAndUnpack(url, targetDir string) {
 			f.Close()
 		}
 	}
+	fmt.Printf("Fetched Bundle without errors")
 }

src/helperBinary.ts

@@ -36,25 +36,31 @@ export async function downloadCompilerBundle(store: Store) {
 		let url = `https://blob.dolansoft.org/soicode/compilerbundle-${platform}-${flavor}.tar.xz`;
 		let targetDir = path.join(store.soicodeExtensionDataPath, "bundle", flavor);
 		let proc = child_process.exec(
-			`${getHelperPath(
+			`'${getHelperPath(
 				store
-			)} fetchBundle --url ${url} --targetDir ${targetDir}`
+			)}' fetchBundle --url '${url}' --targetDir '${targetDir}'`
 		);
 		console.log(
-			`${getHelperPath(
+			`'${getHelperPath(
 				store
-			)} fetchBundle --url ${url} --targetDir ${targetDir}`
+			)}' fetchBundle --url '${url}' --targetDir '${targetDir}'`
 		);
 		let stdout = "";
 		proc.stdout.on("data", chunk => {
 			stdout += chunk;
 		});
 		proc.on("exit", (code, signal) => {
+			console.log(
+				"fetching the compilerbundle finished, errorcode: " +
+					code +
+					"  stdout: " +
+					stdout
+			);
 			if (code !== 0) {
-				console.log(
-					"Error fetching the compilerbundle, errorcode:" +
+				vscode.window.showErrorMessage(
+					"Error fetching the compilerbundle, errorcode: " +
 						code +
-						"stdout:" +
+						"  stdout: " +
 						stdout
 				);
 			}